Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gated-plugin and multiple-plugins tests fail on stage one #99295

Closed
ChrisDenton opened this issue Jul 15, 2022 · 1 comment · Fixed by #99298
Closed

gated-plugin and multiple-plugins tests fail on stage one #99295

ChrisDenton opened this issue Jul 15, 2022 · 1 comment · Fixed by #99298

Comments

@ChrisDenton
Copy link
Member

ChrisDenton commented Jul 15, 2022

On x86_64-pc-windows-msvc the src/test/ui-fulldeps/gated-plugin.rs and ui-fulldeps/multiple-plugins.rs tests fail on stage 1 but succeed in stage 2.

Abbreviated error output:

---- [ui] src/test\ui-fulldeps\gated-plugin.rs stdout ----

--- stderr -------------------------------
error: LoadLibraryExW failed
  --> R:\rust\src/test\ui-fulldeps\gated-plugin.rs:3:11
   |
LL | #![plugin(empty_plugin)]
   |           ^^^^^^^^^^^^

error: aborting due to previous error
------------------------------------------
---- [ui] src/test\ui-fulldeps\multiple-plugins.rs stdout ----

--- stderr -------------------------------
error: LoadLibraryExW failed
  --> R:\rust\src/test\ui-fulldeps\multiple-plugins.rs:8:11
   |
LL | #![plugin(multiple_plugins_1)] //~ WARN use of deprecated attribute `plugin`
   |           ^^^^^^^^^^^^^^^^^^

error: aborting due to previous error
------------------------------------------

I guess one solution would be to make them stage 2 only?

@mati865
Copy link
Contributor

mati865 commented Jul 17, 2022

FWIW they have been also failing on windows-gnu since forever when using stage 1 as well but never bothered to investigate it 😄

@bors bors closed this as completed in a9dc6a6 Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants