-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build won't complete for binary crate under rustc 1.56. #90180
Comments
The Cargo.toml also has two versions of tokio: [dependencies]
tokio = { version = "0.2", features = ["time", "signal", "fs", "io-util", "macros"] }
tokio_1 = { package = "tokio", version = "1.7", features = ["rt", "rt-multi-thread"] } |
@Mark-Simulacrum FYI, I added this to the "Regressions 1.56" project board. Let me know if that's not where it should go. |
I tried to bisect a nightly version that reproduces the problem without success. |
I have the same problem, perf report is virtually identical. Edit: Perf report
`cargo tree`
Edit 2: In my case it is related to |
@jcdyer To further bisect, I suggest making a local copy of the offending package (if it isn't already local) and modifying it so that it can work without |
I just had the same issue, my project builds in 5 minutes with |
Assigning priority as discussed in the Zulip thread of the Prioritization Working Group. @rustbot label -I-prioritize +P-high |
I patched out wasmer-runtime-core (Which had the cfg_attr declarations), and started playing around with nightlies. My project now builds in a reasonable amount of time now on all nightlies since 2021-12-21. The git log between the last bad nightly and the first good one shows the following commits:
It also builds fine on beta, so 1.59 should resolve this issue. Unless @Madoshakalaka or @malobre report that they're still seeing issues, I'd say this can be closed. |
Works in 1.59 and up. |
I've got a (closed source) crate that builds in under two minutes on rustc 1.55, and won't complete (top measured 67 minutes before I killed it) with rustc 1.56.
All the dependencies built fine. I captured the command to build the final binary with cargo build -v, and then ran that command under perf, and got the following output from
perf report
:By contrast, the perf report for 1.55.0 has no lines above 3.1%, most of which are in ld, and the top lines in rustc are
Code
Not shareable. Some possibly interesting things:
static FOO: &[u8]
variables that getsinclude!()
ed) and sets a couple environment variables.Version it worked on
It most recently worked on:1.55.0
Version with regression
rustc --version --verbose
:@rustbot modify labels: +regression-from-stable-to-stable -regression-untriaged
The text was updated successfully, but these errors were encountered: