Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON format should be cleaned up to use Type::Primitive("never") instead of special-casing #89349

Closed
GuillaumeGomez opened this issue Sep 29, 2021 · 0 comments · Fixed by #89669
Closed

JSON format should be cleaned up to use Type::Primitive("never") instead of special-casing #89349

GuillaumeGomez opened this issue Sep 29, 2021 · 0 comments · Fixed by #89669
Labels
A-rustdoc-json Area: Rustdoc JSON backend C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

From #89297 (comment).
@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 29, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue Sep 29, 2021
Merged
@camelid camelid changed the title JSON format should be cleaned up to use Type::Primitive("never") instead of special-casing JSON format should be cleaned up to use Type::Primitive("never") instead of special-casing Sep 29, 2021
@camelid camelid added A-rustdoc-json Area: Rustdoc JSON backend C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Sep 29, 2021
@Urgau Urgau mentioned this issue Oct 8, 2021
Merged
@bors bors closed this as completed in 4adc8ea Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-json Area: Rustdoc JSON backend C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove special-casing of never primitive in rustdoc-json-types Urgau/rust
2 participants
@GuillaumeGomez @camelid