Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: From trait implementation in actix-web 4.0.0-beta.8 is missing from docs #88007

Closed
jplatte opened this issue Aug 13, 2021 · 4 comments
Closed

Comments

@jplatte
Copy link
Contributor

jplatte commented Aug 13, 2021

This page is missing any mention of this trait implementation despite there being no #[doc(hidden)] attribute on the impl or any of the involved types. I have no idea what might be going on.

@Urgau
Copy link
Member

Urgau commented Aug 13, 2021

The trait implementation you are referring to is not missing, in fact it's the latest on "Trait Implementations".

@jplatte
Copy link
Contributor Author

jplatte commented Aug 13, 2021

Now I'm really confused. I went over the page multiple times and found no generic From impl except the blanket impl from std. I searched for ResponseError on the page and it wasn't there in the later parts of the page. I guess I'll close this.

@jplatte jplatte closed this as completed Aug 13, 2021
@jplatte
Copy link
Contributor Author

jplatte commented Aug 16, 2021

Turned out I linked the wrong error page, the type where I was expecting the impl to show up was actix_web::error::Error¹, a.k.a. actix_http::error::Error, which is not the same thing as actix_web::Error. There the impl really doesn't exist, at least in the same file (which has me very confused how the generics work out in practice but I'm okay with that for now).

¹ which also appears twice in the docs! (here)

@aliemjay
Copy link
Member

aliemjay commented Sep 5, 2021

It turned out that actix_web::error::Error is the same as actix_web::Error! The problem is rustdoc links to the wrong page (see my comment on #70380). This got me confused for hours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants