Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--enable-valgrind succeeds if valgrind is not installed. mac bots are not valgrinding #8267

Closed
brson opened this issue Aug 3, 2013 · 2 comments
Closed

--enable-valgrind succeeds if valgrind is not installed. mac bots are not valgrinding #8267

brson opened this issue Aug 3, 2013 · 2 comments

Comments

@brson
Copy link
Contributor

brson commented Aug 3, 2013

The configure script does not error if --enable-valgrind is specified but valgrind does not exist. This is resulting in situations where our mac valgrind bots are not actually valgrinding:

http://buildbot.rust-lang.org/builders/auto-mac-64-opt-vg/builds/712/steps/configure/logs/stdio

I have seen valgrind errors on the mac valgrind builder though, so presumably some of the slaves do have valgrind.
@brson brson mentioned this issue Aug 8, 2013
Closed
@catamorphism
Copy link
Contributor

Still a bug as far as I know, but doesn't seem like a release blocker to me.

@alexcrichton alexcrichton mentioned this issue Mar 31, 2014
Closed
@alexcrichton
Copy link
Member

This has been fixed as the tests will error if they don't find valgrind by default. This is enabled for the valgrind tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @brson @catamorphism