Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x.py test src/tools/cargo --test-args x does not pass x as an argument #82621

Closed
jyn514 opened this issue Feb 28, 2021 · 0 comments · Fixed by #82622
Closed

x.py test src/tools/cargo --test-args x does not pass x as an argument #82621

jyn514 opened this issue Feb 28, 2021 · 0 comments · Fixed by #82622
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Feb 28, 2021

I tried this: x.py test src/tools/cargo --test-args message_format
I expected to see this happen: x.py only runs cargo tests with message_format in the name.
Instead, this happened: x.py runs all cargo tests:

running: "/home/joshua/rustc3/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "8" "--release" "--manifest-path" "/home/joshua/rustc3/src/tools/cargo/Cargo.toml"

Meta

I'm using 5d02aa1150a2afea958bbeacaa7683ba3a8f00f3 (branched from 8a9f786).
@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself labels Feb 28, 2021
@jyn514 jyn514 mentioned this issue Feb 28, 2021
Merged
@bors bors closed this as completed in d65b231 Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate --test-args for x.py test src/tools/cargo jyn514/rust
1 participant
@jyn514