rustdoc page styles are broken with Waterfox

[ensc]

https://docs.rs does not work with Waterfox because it relies on the non-standard disabled="" Attribute in the theme <link> tags:

      <link href="/light-20200726-1.47.0-nightly-6c8927b0c.css" id="themeStyle" rel="stylesheet" type="text/css">
      <link disabled="" href="/dark-20200726-1.47.0-nightly-6c8927b0c.css" rel="stylesheet" type="text/css">
      <link disabled="" href="/ayu-20200726-1.47.0-nightly-6c8927b0c.css" rel="stylesheet" type="text/css">

Without "disabled" support (which is the case with Waterfox), all three links will be enabled and will make the (imo unreadable) "ayu" the active one.

Accordingly https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link this attribute requires very recent browsers and is marked as "Deprecated: do not use for new websites"

[jyn514]

This is a rustdoc issue, not docs.rs. I transferred to rust-lang/rust.

[jyn514]

Can you give an example page where this happens?

[ensc]

It happens with every crate on https://docs.rs E.g. https://docs.rs/griddle/0.3.1/griddle/ (randomly selected by "I'm feeling lucky")

[jyn514]

I don't see it on https://docs.rs/postgres/0.17.0-alpha.2/postgres/. So it looks like it might have been introduced as part of the Ayu theme, cc @Cldfire

[jyn514]

Would the fix be as simple as changing disabled="" to disabled?

[jyn514]

Hmm, this looks like the relevant code, but it uses disabled, not disabled="".

rust/src/librustdoc/html/layout.rs

Lines 172 to 186 in 0e89f50

	style_files = style_files
	.iter()
	.filter_map(|t| {
	if let Some(stem) = t.path.file_stem() { Some((stem, t.disabled)) } else { None }
	})
	.filter_map(|t| {
	if let Some(path) = t.0.to_str() { Some((path, t.1)) } else { None }
	})
	.map(|t| format!(
	r#"<link rel="stylesheet" type="text/css" href="{}.css" {} {}>"#,
	Escape(&format!("{}{}{}", static_root_path, t.0, page.resource_suffix)),
	if t.1 { "disabled" } else { "" },
	if t.0 == "light" { "id=\"themeStyle\"" } else { "" }
	))
	.collect::<String>(),

[ensc]

@jyn514 yes; the postgres link is ok (seems to be generated by rust-1.41). It affects probably crates which were uploaded recently.

Trying to change disabled="" to disabled in Webdeveloper does not seem to have any effect. The disabled Attribute is probably not supported at all by Waterfox; the browser is based on Firefox 56 and disabled requires version 68 at least.

[jyn514]

https://rust-lang.github.io/rfcs/1985-tiered-browser-support.html#supported-browsers

Goal: Ensure functionality of our web content for 80% of users.
Browsers:

• last 1 Firefox version
• Firefox ESR

The latest ESR of firefox is 68: https://www.mozilla.org/en-US/firefox/68.0esr/releasenotes/

So I'm inclined to close this as wontfix.

[ensc]

Accordingly https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link#Browser_compatibility it is not supported by Safari either (which is in your list).

As already noted, page above says about this attribute "Deprecated. Not for use in new websites." and "Non-standard. Expect poor cross-browser support".

[Nemo157]

Changing styles appears to work fine on recent mobile and desktop Safari, so if it's not supported, it's not supported in a way which doesn't break anything.

[ensc]

Nevertheless, it is bad to rely on deprecated and proprietary extensions and break websites completely.

[jyn514]

@ensc I understand your viewpoint and I realize this is frustrating. However the rustdoc team has limited time and resources, and we have to choose how to spend it. If you have ideas how to fix this feel free to make a PR and I (or another team member) would be happy to review it.

[Cldfire]

@ensc I apologize for the problem I created here with my PR! It's never fun to have one's setup broken by changes made elsewhere, and for that I am sorry.

I was actually unaware that the disabled attribute on link elements is discouraged from use, so thank you for bringing that to our attention here, I appreciate it.

As others in this thread have made clear, the browser support target around here is fairly recent. This is a consequence of the fact that most of us are unpaid volunteers, and while we do care deeply about the end users of Rust, we are limited in the time and energy we posses to keep things working for older and / or more niche setups, unfortunately.

That being said, I definitely agree that it would be in everyone's best interest to move away from the use of the disabled attribute on link elements here. I will take a look tomorrow and see if it's feasible to replace it with something better.

In particular, it appears that the mdbook project uses StyleSheet.disabled (as seen here), and that method is not deprecated and appears to have much better browser support.

Using that instead could perhaps improve the situation here for all parties concerned.

[Cldfire]

Opened #75063 which will fix this problem for you @ensc 😄