Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship compiletest as part of rustc-dev #73603

Closed
Manishearth opened this issue Jun 22, 2020 · 5 comments
Closed

Ship compiletest as part of rustc-dev #73603

Manishearth opened this issue Jun 22, 2020 · 5 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@Manishearth
Copy link
Member

Manishearth commented Jun 22, 2020

(Maybe we should have a meta tracking issue for subtree things, e.g. moving rustfmt and rustdoc over to subtree)

As clippy is fleshing out the subtree model, I wonder if it's worth shipping compiletest in rustc-dev so that rustc and clippy are always using the same compiletest.

cc @Mark-Simulacrum @flip1995

@LeSeulArtichaut LeSeulArtichaut added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jun 22, 2020
@RalfJung
Copy link
Member

Miri would also be interested in this (though porting it entirely to ui tests could be hard in case compiletest lost support for some of the other modes).

@euclio
Copy link
Contributor

euclio commented Jun 22, 2020

This is a great idea! Notably, clippy's compiletest doesn't currently have #59408 in it, which causes test output that has backslashes to be pretty confusing: https://github.com/rust-lang/rust-clippy/blob/742706511c9f33c6a0d4380392e513e5249057e3/tests/ui/print_with_newline.stderr#L4

@Mark-Simulacrum
Copy link
Member

Shipping the binary seems feasible, though it would be a small bump in CI times.

@tamird
Copy link
Contributor

tamird commented Jul 29, 2023

This is probably no longer relevant now that clippy is using ui-test?

@RalfJung
Copy link
Member

Yeah, and Miri too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

No branches or pull requests

6 participants