Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for generator code quality #71407

Open
1 task
tmandry opened this issue Apr 21, 2020 · 3 comments
Open
1 task

Tracking issue for generator code quality #71407

tmandry opened this issue Apr 21, 2020 · 3 comments
Labels
A-async-await Area: Async & Await A-coroutines Area: Coroutines A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. I-heavy Issue: Problems and improvements with respect to binary size of generated code. I-slow Issue: Problems and improvements with respect to performance of generated code. metabug Issues about issues themselves ("bugs about bugs") T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@tmandry
Copy link
Member

tmandry commented Apr 21, 2020

So far we haven't done many deep dives into the code LLVM produces for generators. I think there's a lot of room for improvement here, both in the compiler and in LLVM.

Issues (please add more as they come up):

Some more ideas are in #71093 (comment)

Related tracking issues:

@tmandry tmandry added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-coroutines Area: Coroutines A-async-await Area: Async & Await labels Apr 21, 2020
@jonas-schievink jonas-schievink added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. I-heavy Issue: Problems and improvements with respect to binary size of generated code. I-slow Issue: Problems and improvements with respect to performance of generated code. labels Apr 21, 2020
@Mark-Simulacrum
Copy link
Member

@tmandry It'd be good to have a handle on when we expect to close this (e.g., is this an 'active work' type issue or not)

@tmandry
Copy link
Member Author

tmandry commented Apr 21, 2020

@tmandry It'd be good to have a handle on when we expect to close this (e.g., is this an 'active work' type issue or not)

It's more of a place to group issues that are related so we can better track work. The other two tracking issues I linked above are more examples of this.

I don't know if we can ever expect to be "done" with improving generator memory usage, for instance, but if all known problems are fixed (or not going to be) then we can close the issue.

EDIT: I have a few code quality-related issues I could add here, as things to investigate or future projects, I just haven't written them up yet.

@tmandry tmandry added the AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. label Apr 28, 2020
@pnkfelix
Copy link
Member

pnkfelix commented Sep 9, 2022

Visiting during T-compiler backlog bonanza. This isn't the same kind of "tracking issue" that we associated with the C-tracking-issue label (in terms of a specific feature being designed)

@rustbot label: +metabug -C-tracking-issue

@rustbot rustbot added metabug Issues about issues themselves ("bugs about bugs") and removed C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC labels Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-async-await Area: Async & Await A-coroutines Area: Coroutines A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. I-heavy Issue: Problems and improvements with respect to binary size of generated code. I-slow Issue: Problems and improvements with respect to performance of generated code. metabug Issues about issues themselves ("bugs about bugs") T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants