Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: properly connect cargo check and cargo build #65427

Open
crlf0710 opened this issue Oct 15, 2019 · 4 comments
Open

request: properly connect cargo check and cargo build #65427

crlf0710 opened this issue Oct 15, 2019 · 4 comments
Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@crlf0710
Copy link
Member

Currently cargo check and cargo build works in isolate. A much better way is get them connected. So that:

  • After a successful cargo build, a cargo check should pick up the incremental build data, and finish (almost) immediately without doing real work.
  • After a successful cargo check, a cargo build should pick up the incremental build data, and continue to do the codegen part, instead of starting from scratch.
@Centril Centril added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-incr-comp Area: Incremental compilation labels Oct 15, 2019
@varkor
Copy link
Member

varkor commented Oct 15, 2019

Previously reported at #50037. cargo issue: rust-lang/cargo#3501.

@jonas-schievink

This comment has been minimized.

@varkor

This comment has been minimized.

@crlf0710
Copy link
Member Author

#50037 is about rustbuild so that's different...at least on the surface.

This is the same as cargo#3501 though. But i feel this is actually a rustc problem with incremental build and metadata format in the root. And it's more visible in this repo :) Maybe i should not close it as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-incr-comp Area: Incremental compilation C-enhancement Category: An issue proposing an enhancement or a PR with one. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants