Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: conflicting implementations of trait for Into<Box> #61471

Closed
Mark-Simulacrum opened this issue Jun 3, 2019 · 4 comments
Closed
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

#46328 is a very old similar issue

root: bow - 5 detected crates which regressed due to this; cc @clarcharr

 * hostman-0.4.0: [start](https://crater-reports.s3.amazonaws.com/beta-1.36-2/1.35.0/reg/hostman-0.4.0/log.txt) v. [end](https://crater-reports.s3.amazonaws.com/beta-1.36-2/beta-2019-05-30/reg/hostman-0.4.0/log.txt); cc @lucascaro
 * multistr-0.5.4: [start](https://crater-reports.s3.amazonaws.com/beta-1.36-2/1.35.0/reg/multistr-0.5.4/log.txt) v. [end](https://crater-reports.s3.amazonaws.com/beta-1.36-2/beta-2019-05-30/reg/multistr-0.5.4/log.txt); cc @clarcharr
 * parse-hosts-0.5.0: [start](https://crater-reports.s3.amazonaws.com/beta-1.36-2/1.35.0/reg/parse-hosts-0.5.0/log.txt) v. [end](https://crater-reports.s3.amazonaws.com/beta-1.36-2/beta-2019-05-30/reg/parse-hosts-0.5.0/log.txt); cc @clarcharr
 * swc-hosts-0.2.1: [start](https://crater-reports.s3.amazonaws.com/beta-1.36-2/1.35.0/reg/swc-hosts-0.2.1/log.txt) v. [end](https://crater-reports.s3.amazonaws.com/beta-1.36-2/beta-2019-05-30/reg/swc-hosts-0.2.1/log.txt); cc @clarcharr
 * lucascaro/hostman: [start](https://crater-reports.s3.amazonaws.com/beta-1.36-2/1.35.0/gh/lucascaro.hostman/log.txt) v. [end](https://crater-reports.s3.amazonaws.com/beta-1.36-2/beta-2019-05-30/gh/lucascaro.hostman/log.txt); cc @lucascaro

root: pin-api - 1 detected crates which regressed due to this; cc @withoutboats

 * pin-api-0.2.1: [start](https://crater-reports.s3.amazonaws.com/beta-1.36-2/1.35.0/reg/pin-api-0.2.1/log.txt) v. [end](https://crater-reports.s3.amazonaws.com/beta-1.36-2/beta-2019-05-30/reg/pin-api-0.2.1/log.txt); cc @withoutboats
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Jun 3, 2019
@Centril
Copy link
Contributor

Centril commented Jun 3, 2019

I'm guessing this is due to #49799.

@Centril
Copy link
Contributor

Centril commented Jun 3, 2019

cc @clarfon

@clarfonthey
Copy link
Contributor

I had deprecated the crate and mentioned that exact issue in its description. The latest release simply includes nothing and the readme has a link to that issue. It should be blacklisted by crater.

@pnkfelix
Copy link
Member

pnkfelix commented Jun 4, 2019

I discussed with @pietroalbini whether crater should blacklist the bow crate.

If I understand correctly, blacklisting bow would not actually address the issue, since the problem building bow would still arise when we attempt to build the downstream crates that (directly or indirectly) depend on bow.

Here is a ascii-art graph showing the reverse dependencies here

bow --> multistr --> parse-hosts --> swc-hosts
                         |
                         '---------> hostman

The top four crates are all authored by @clarfon. I couldn't find any active repositories for those crates (all the links in the crates.io metadata are dead), so i couldn't file any issues against them.

I filed lucascaro/hostman#4 about the crate on the bottom of the graph.

I don't think there's anything further that we should do on our end about this. So I'm closing this as expected fallout from #49799.

@pnkfelix pnkfelix closed this as completed Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants