Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#60679 #60768

Closed
rust-highfive opened this issue May 12, 2019 · 6 comments
Closed

rls no longer builds after rust-lang/rust#60679 #60768

rust-highfive opened this issue May 12, 2019 · 6 comments
Assignees
@pnkfelix @Xanewok @petrochenkov
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #60679, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @petrochenkov, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @matklad, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 12, 2019
@matklad
Copy link
Member

matklad commented May 12, 2019

RLS builds with cargo build --no-default-features, so it's a Clippy issue

@Xanewok
Copy link
Member

Xanewok commented May 13, 2019

Related Clippy PR: rust-lang/rust-clippy#4093

@pnkfelix
Copy link
Member

rust-lang/rust-clippy#4093 has landed; is there an easy way to check whether the rls tool now builds?

@pnkfelix
Copy link
Member

in terms of triage: P-medium, removing nomination tag, and assigning to self to ensure this does not get lost.

@pnkfelix pnkfelix self-assigned this May 16, 2019
@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels May 16, 2019
@oli-obk
Copy link
Contributor

oli-obk commented May 16, 2019

I am working on #60848 to get rls to work again

@oli-obk oli-obk mentioned this issue May 17, 2019
Closed
@petrochenkov
Copy link
Contributor

Fixed or at least a duplicate of #61071.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pnkfelix pnkfelix

@Xanewok Xanewok

@petrochenkov petrochenkov

Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change clippy's symbol interning strategy to be reentrant oli-obk/rust
6 participants
@pnkfelix @oli-obk @matklad @Xanewok @petrochenkov @rust-highfive