Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PathBuf pop()s even if file_name is None #59714

Closed
pongad opened this issue Apr 5, 2019 · 3 comments
Closed

PathBuf pop()s even if file_name is None #59714

pongad opened this issue Apr 5, 2019 · 3 comments

Comments

@pongad
Copy link
Contributor

pongad commented Apr 5, 2019

Playground link

The documentation states that pop should do nothing and return false if file_name is None, but it returns true and actually removes the ".." component.
@Stargateur
Copy link
Contributor

Stargateur commented Apr 5, 2019 •
edited
Loading

it's more a documentation error and should be "if parent() return None"

@Stargateur
Copy link
Contributor

Stargateur commented Apr 5, 2019 •
edited
Loading

Duplicate of #58474 already fix in #58496

@pongad
Copy link
Contributor Author

pongad commented Apr 5, 2019

Ah thank you for the pointer!

@pongad pongad closed this as completed Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pongad @Stargateur