Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for udp_peer_addr #59127

Closed
LinusU opened this issue Mar 12, 2019 · 11 comments · Fixed by #64728
Closed

Tracking issue for udp_peer_addr #59127

LinusU opened this issue Mar 12, 2019 · 11 comments · Fixed by #64728
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@LinusU
Copy link
Contributor

LinusU commented Mar 12, 2019 •
edited
Loading

Tracking issue for making peer_addr() on UdpSocket stable: #59106, #59104
@sanxiyn

This comment has been minimized.

Sign in to view
@jonas-schievink jonas-schievink added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC labels Mar 13, 2019
@jonas-schievink

This comment has been minimized.

Sign in to view
@MOZGIII
Copy link
Contributor

MOZGIII commented May 1, 2019

How about moving this to stable?

@ghedo
Copy link
Contributor

ghedo commented Jun 7, 2019

What's left to do to stabilize this feature? Any ETA?

@MOZGIII MOZGIII mentioned this issue Jun 12, 2019
Closed
@Thomasdezeeuw
Copy link
Contributor

Can this be stablised for 1.37?

@Thomasdezeeuw Thomasdezeeuw mentioned this issue Jul 8, 2019
Closed
@ghost
Copy link

ghost commented Aug 4, 2019 •
edited by ghost
Loading

Another reminder -- can we kick off FCP for stabilization?

@Dylan-DPC-zz
Copy link

@rust-lang/libs any updates?

@sfackler
Copy link
Member

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Aug 24, 2019 •
edited by Amanieu
Loading

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Aug 24, 2019
@rfcbot
Copy link

rfcbot commented Aug 30, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Aug 30, 2019
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Sep 9, 2019
@rfcbot
Copy link

rfcbot commented Sep 9, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@messense messense mentioned this issue Sep 24, 2019
Merged
@bors bors closed this as completed in 019b5b5 Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize UdpSocket::peer_addr
9 participants
@sanxiyn @ghedo @LinusU @MOZGIII @sfackler @jonas-schievink @Thomasdezeeuw @Dylan-DPC-zz @rfcbot