Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls no longer builds after rust-lang/rust#58321 #58765

Closed
rust-highfive opened this issue Feb 27, 2019 · 5 comments
Closed

rls no longer builds after rust-lang/rust#58321 #58765

rust-highfive opened this issue Feb 27, 2019 · 5 comments
Assignees
Labels
P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #58321, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @csmoe, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @oli-obk, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.

@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 27, 2019
@pnkfelix
Copy link
Member

triage: P-high. Leaving nominated for discussion.

@pnkfelix pnkfelix added the P-high High priority label Feb 28, 2019
@Xanewok
Copy link
Member

Xanewok commented Feb 28, 2019

This is clippy-related fallout - I believe updating Clippy to the version updated in rust-lang/rust-clippy#3827 should fix the toolstate.

@csmoe
Copy link
Member

csmoe commented Feb 28, 2019

@Xanewok yep I updated it just now rust-lang/rls#1384

@Xanewok
Copy link
Member

Xanewok commented Feb 28, 2019

A follow-up PR to the RLS repo is highly appreciated (this fixes repo local build) but to fix the toolstate we need to bump the Clippy version in the Rust repo, since we patch those at

rust/Cargo.toml

Lines 71 to 72 in 7e001e5

[patch."https://github.com/rust-lang/rust-clippy"]
clippy_lints = { path = "src/tools/clippy/clippy_lints" }

@Xanewok
Copy link
Member

Xanewok commented Mar 4, 2019

Fixed in #58807 (This took longer than expected due to broken crates.io compiletest_rs package).

@oli-obk oli-obk closed this as completed Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants