Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcore can use unstable library features without a feature flag #58705

Open
RalfJung opened this issue Feb 24, 2019 · 0 comments
Open

libcore can use unstable library features without a feature flag #58705

RalfJung opened this issue Feb 24, 2019 · 0 comments
Labels
A-stability Area: `#[stable]`, `#[unstable]` etc. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

I've been assuming that feature flags can also be used "within" the standard library to control which features are already being used. That is helpful when stabilizing a part of the API, to test if that API is viable enough for whatveer the standard library does with it.

But it turns out that, e.g., core::fmt::float can call MaybeUninit::get_mut without enabling the relevant feature flag. That seems like a bug to me.
@jonas-schievink jonas-schievink added A-stability Area: `#[stable]`, `#[unstable]` etc. C-bug Category: This is a bug. labels Feb 24, 2019
@Enselic Enselic added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-stability Area: `#[stable]`, `#[unstable]` etc. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Enselic @RalfJung @jonas-schievink