Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remap-debuginfo config.toml option broken when building a release #55341

Closed
Keruspe opened this issue Oct 25, 2018 · 0 comments
Closed

remap-debuginfo config.toml option broken when building a release #55341

Keruspe opened this issue Oct 25, 2018 · 0 comments

Comments

@Keruspe
Copy link
Contributor

Keruspe commented Oct 25, 2018

Trying to build 1.30.0 with remap-debuginfo enabled results in

thread 'main' panicked at 'failed to find sha', libcore/option.rs:989:5

rustbuild tries to get the sha from the current commit when we are not in a git repository

Keruspe added a commit to Keruspe/rust that referenced this issue Oct 25, 2018
Fallback to the release number as we can't get the
git commit sha as we're not in a git repository.

Fixes rust-lang#55341

Signed-off-by: Marc-Antoine Perennou <[email protected]>
kennytm added a commit to kennytm/rust that referenced this issue Oct 26, 2018
…alexcrichton

rustbuild: fix remap-debuginfo when building a release

Fallback to the release number as we can't get the git commit sha as we're not in a git repository.

Fixes rust-lang#55341
kennytm added a commit to kennytm/rust that referenced this issue Oct 26, 2018
…alexcrichton

rustbuild: fix remap-debuginfo when building a release

Fallback to the release number as we can't get the git commit sha as we're not in a git repository.

Fixes rust-lang#55341
pietroalbini pushed a commit to pietroalbini/rust that referenced this issue Oct 31, 2018
Fallback to the release number as we can't get the
git commit sha as we're not in a git repository.

Fixes rust-lang#55341

Signed-off-by: Marc-Antoine Perennou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant