Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose libproc_macro in rust-src component #53463

Closed
kngwyu opened this issue Aug 18, 2018 · 5 comments
Closed

Expose libproc_macro in rust-src component #53463

kngwyu opened this issue Aug 18, 2018 · 5 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@kngwyu
Copy link
Contributor

kngwyu commented Aug 18, 2018

To use it for racer completion.
cc @nrc
@nrc nrc added A-build T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 21, 2018
@nrc
Copy link
Member

nrc commented Aug 21, 2018

@rust-lang/infra IS there a downside to doing this?

@kennytm
Copy link
Member

kennytm commented Aug 21, 2018

No problem for me.

@Mark-Simulacrum
Copy link
Member

Slightly increased file sizes, but presumably not that big a problem.

@aidanhs
Copy link
Member

aidanhs commented Aug 21, 2018

Discussed this in an infra team meeting, we don't see any issues.

@Xanewok
Copy link
Member

Xanewok commented Nov 9, 2018

It seems this was done already in #55280.

@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-build labels Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kennytm @nrc @aidanhs @jonas-schievink @Xanewok @Mark-Simulacrum @kngwyu