bs58 crate fails to build tests in 1.28 beta

[pietroalbini]

That test code doesn't make sense to me... but it was working in 1.27 somehow.

• bs58 regressed from stable to beta (build log) cc @Nemo157

[Nemo157]

::decode is both a module and a function.

Throwing together a test playground indicates that the issue could be #38260, but if so I'm not sure why it was building on 1.27. I'm installing 1.27 locally right now to check.

[Nemo157]

Yeah, I get the same error when running the tests with 1.27 locally:

error: `self` no longer imports values
   --> bs58-rs/src/decode.rs:150:19
    |
150 |     use decode::{ self, DecodeError };
    |                   ^^^^
    |
    = note: #[deny(legacy_imports)] on by default
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #38260 <https://github.com/rust-lang/rust/issues/38260>

Guess I need to fix that.

[pietroalbini]

::decode is both a module and a function.

Oh, I didn't check in the lib.rs file. That explains it.

Thanks for looking into this @Nemo157! I'm closing the issue as won't fix.