Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure should print the command line that failed #4696

Closed
catamorphism opened this issue Jan 30, 2013 · 10 comments
Closed

Build failure should print the command line that failed #4696

catamorphism opened this issue Jan 30, 2013 · 10 comments
Labels
P-low Low priority

Comments

@catamorphism
Copy link
Contributor

Far too often, I've done something like:

$ make check
(wait)
compile_and_link: x86_64-apple-darwin/test/coretest.stage2-x86_64-apple-darwin
*** build error of some sort...

Then I want to run the command that failed by itself, but I don't have it; I can either remember what it is, or run VERBOSE=1 make check and wait. It would be nice if a build failure printed out just the command line that caused the last error. I could run with VERBOSE all the time, but that does get very verbose.

@nikomatsakis
Copy link
Contributor

It turns out that make has a built-in facility for supressing commands (make -s). This facility will printout the command iff it fails. But our makefiles don't seem to be compatible with it.

@msullivan
Copy link
Contributor

It would not be hard to get our makefiles to work properly with make -s, but I'm not sure whether we want to require users to specify it to get the currently default quiet behavior.

There are hacks I am considering that might make this work...

@msullivan
Copy link
Contributor

Oh, although it doesn't look like -s actually prints the command line if it failed...

@msullivan
Copy link
Contributor

One way to do this would be to replace $(Q) with a function that we call. This function would run the command and echo it if it failed. This is an easy but large change, I think.

@emberian
Copy link
Member

emberian commented Aug 5, 2013

Seems relevant, but will be obsolete with #5363

@pnkfelix
Copy link
Member

Assigning P-low.

@huonw
Copy link
Member

huonw commented Mar 2, 2014

part of #8058

@steveklabnik
Copy link
Member

Triage: no change

@steveklabnik
Copy link
Member

Triage: obsoleted by rustbuild, though rustbuild is not yet in place.

@alexcrichton
Copy link
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-low Low priority
Projects
None yet
Development

No branches or pull requests

8 participants