Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single_use_lifetimes should have suggestions #46944

Closed
Manishearth opened this issue Dec 22, 2017 · 2 comments
Closed

single_use_lifetimes should have suggestions #46944

Manishearth opened this issue Dec 22, 2017 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Manishearth
Copy link
Member

This is a new feature, we should be teaching it through error messages.

Currently we just say that a lifetime is single use but do not recommend how to fix it. It leads to confusions like #46873

We should fix that.
@Manishearth Manishearth added the A-diagnostics Area: Messages for errors, warnings, and lints label Dec 22, 2017
@Manishearth Manishearth mentioned this issue Dec 22, 2017
Closed
@leonardo-m
Copy link

I've added another comment in #46873

@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 26, 2018
@jebrosen jebrosen mentioned this issue Jun 15, 2019
Closed
@zackmdavis
Copy link
Member

This was fixed in #55432.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zackmdavis @Manishearth @XAMPPRocky @leonardo-m