Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove structural records from libcore, libstd, macros #4665

Closed
catamorphism opened this issue Jan 29, 2013 · 9 comments
Closed

Remove structural records from libcore, libstd, macros #4665

catamorphism opened this issue Jan 29, 2013 · 9 comments
Labels
A-syntaxext Area: Syntax extensions C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
0.6

Comments

@catamorphism
Copy link
Contributor

libcore has structural records removed for the most part (thanks to @erickt 's heroic work!) but a few modules still have it enabled because the pipes code generates code with structural records. I'm a little afraid to fix the pipes compiler (I'm not sure how to make it generate new names for struct types), but could with some help.

The extfmt code also needs to be changed to not generate structural records.

Finally (for now), libstd needs to have records removed as well.
@erickt
Copy link
Contributor

erickt commented Jan 29, 2013

I already landed my extfmt and pipes patches, and most of libstd has been converted too. I'm just waiting on a snapshot to remove my #[cfg(stage...)] blocks.

@catamorphism
Copy link
Contributor Author

@erickt Great, thanks! Sorry, I must have read your patches hastily and didn't notice that you also fixed extfmt and pipes :-)

@catamorphism
Copy link
Contributor Author

I have a new snapshot ready that should work for this; currently running try.

@ghost ghost assigned catamorphism Jan 29, 2013
@catamorphism
Copy link
Contributor Author

I've de-recorded libstd and am just running tests. I also have a snapshot branch that should build, but is not compiling on the Mac and Linux bots (I'm investigating).

catamorphism added a commit to catamorphism/rust that referenced this issue Feb 5, 2013
@catamorphism
std: Stamp out structural records
73a7672 
See rust-lang#4665
@catamorphism catamorphism mentioned this issue Feb 5, 2013
Closed
bors added a commit that referenced this issue Feb 5, 2013
@bors
auto merge of #4796 : catamorphism/rust/derecord_std, r=catamorphism
f1b05ec 
See #4665
@catamorphism
Copy link
Contributor Author

I forgot to remove one use of structural records from the pipes compiler ( gen_buffer_init in libsyntax/ext/pipec.rs). >:-(

@catamorphism
Copy link
Contributor Author

I'll try to finish this now that df4273f is in. Specifically I'll start a snapshot building.

@catamorphism
Copy link
Contributor Author

Snapshot is now building.

@yjh0502 yjh0502 mentioned this issue Feb 27, 2013
Closed
@bstrie bstrie mentioned this issue Mar 7, 2013
Closed
@bstrie
Copy link
Contributor

bstrie commented Mar 7, 2013

I think this can be closed now.

@catamorphism catamorphism mentioned this issue Mar 21, 2013
Closed
@nikomatsakis
Copy link
Contributor

Records appear to be completely removed from compiler

@catamorphism catamorphism removed their assignment Jun 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-syntaxext Area: Syntax extensions C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
4 participants
@erickt @nikomatsakis @catamorphism @bstrie