Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-ignore range tests on Windows #4636

Closed
catamorphism opened this issue Jan 25, 2013 · 7 comments
Closed

Un-ignore range tests on Windows #4636

catamorphism opened this issue Jan 25, 2013 · 7 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. O-windows Operating system: Windows

Comments

@catamorphism
Copy link
Contributor

07d0af1 ignored some int::range and uint::range tests that were failing on Windows. Figure out why, and un-ignore them.
@catamorphism
Copy link
Contributor Author

I wonder if this is the same bug as #4704 (though I don't think times is involved).

@catamorphism
Copy link
Contributor Author

Not critical for 0.6, de-milestoning

@catamorphism
Copy link
Contributor Author

Nominating for milestone 5, production-ready

@graydon
Copy link
Contributor

graydon commented May 23, 2013

accepted for production-ready milestone

@emberian
Copy link
Member

These tests are still ignored. Someone with windows will need to confirm that they're still broken.

@emberian
Copy link
Member

For reference, this is lines around 720 in src/libstd/num/uint_macros.rs (and int_macros.rs)

@thestinger
Copy link
Contributor

These tests are now replaced by the ones in std::iter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. O-windows Operating system: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graydon @catamorphism @emberian @thestinger