Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twists beta regression #43955

Closed
est31 opened this issue Aug 17, 2017 · 2 comments
Closed

twists beta regression #43955

est31 opened this issue Aug 17, 2017 · 2 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Aug 17, 2017

twists commit https://github.com/rustyhorde/twists/commit/4490db4201265c28c9f05f469d0d010181f65b22 regressed from stable to beta (full log):

Aug 17 12:50:15.558 INFO kablam! error: type `slog::NeverStruct` is private
Aug 17 12:50:15.558 INFO kablam!   --> /cargo-home/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/twist-jwt-0.3.1/src/client.rs:16:5
Aug 17 12:50:15.559 INFO kablam!    |
Aug 17 12:50:15.559 INFO kablam! 16 |     stdout: Option<Logger>,
Aug 17 12:50:15.559 INFO kablam!    |     ^^^^^^^^^^^^^^^^^^^^^^
Aug 17 12:50:15.559 INFO kablam!

cc @rustyhorde
@est31
Copy link
Member Author

est31 commented Aug 17, 2017

Similarly for twisty (log).

@bstrie bstrie added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Aug 18, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Aug 20, 2017
@alexcrichton alexcrichton added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 20, 2017
@alexcrichton
Copy link
Member

I believe the compiler/lang teams won't be reverting #42125, so I'm going to close this regression tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @bstrie @Mark-Simulacrum @est31