-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current libc integration is a huge hack #42773
Comments
Is the |
No its only a feature, it can't be used for conditional compilation. The libc crate needs actual conditional compilation (we can remove those last 3 lines probably, but not the 3 I marked). |
@est31 Ah right. Sorry. What about (BTW is this piece of code in |
Lol, lets not do that.
I think so, yes. Be welcome to file a PR I guess :) |
Okay I'll close this per discussion with @alexcrichton on IRC -- currently there seems no better way to solve this, due to dependencies on libcore/libstd. |
Currently, the integration of the libc crate is very very hacky.
src/rustc/libc_shim
) for the sole purpose of passing a cfg flagstdbuild
to the crate.I propose we revive the
rustbuild
feature that has been removed by #42495 and:rustbuild
cfg flag removed by Bump to 1.20.0 and update stage0 compiler #42495 and use it instead ofstdbuild
The text was updated successfully, but these errors were encountered: