Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mark str representation example as "don't actually do this" #33637

Closed
birkenfeld opened this issue May 14, 2016 · 4 comments
Closed

doc: mark str representation example as "don't actually do this" #33637

birkenfeld opened this issue May 14, 2016 · 4 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@birkenfeld
Copy link
Contributor

The example here led to some confusion how to get a slice from a Vec<u8>: https://users.rust-lang.org/t/checking-for-incoming-data-on-tcpstream/5814/7

The example code should probably be flagged as "don't do this in practice, this is just to show the innards".
@steveklabnik steveklabnik added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. labels Jun 27, 2016
@steveklabnik
Copy link
Member

I am willing to mentor anyone who wants to fix this

@steveklabnik steveklabnik added the E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. label Jun 27, 2016
@JessRudder
Copy link
Contributor

@steveklabnik I'm looking to do my first open source commit and this seems handleable. :) Should I follow the instructions for documentation in the contributing.md and see how far I can get on this?

@steveklabnik
Copy link
Member

@JessRudder yup! If you need any specific help, leave a comment or drop by IRC :)

@JessRudder JessRudder mentioned this issue Aug 12, 2016
Merged
@kyrias
Copy link
Contributor

kyrias commented Aug 19, 2016

(This should be closed now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @birkenfeld @kyrias @JessRudder