Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc not rendering some trait impls for BTreeSet and HashSet #20175

Closed
csouth3 opened this issue Dec 23, 2014 · 1 comment
Closed

Rustdoc not rendering some trait impls for BTreeSet and HashSet #20175

csouth3 opened this issue Dec 23, 2014 · 1 comment
Assignees
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@csouth3
Copy link
Contributor

csouth3 commented Dec 23, 2014

I noticed today that the rustdoc pages for BTreeSet and HashSet are both missing the sets' impls of BitOr, BitAnd, BitXor, and Sub. The page for (for example) BitOr itself lists HashSet and BTreeSet as implementors (http://doc.rust-lang.org/std/ops/trait.BitOr.html, though HashSet is listed twice, I don't know what's up there either), so rustdoc is aware of the implementations, but clicking through to either set's page (e.g. http://doc.rust-lang.org/std/collections/struct.HashSet.html), the trait impls aren't there.

I know for sure the impls for BTreeSet were rendered before #19448, so the fact that the impls changed from e.g. for BTreeSet<T> to for &'a BTreeSet<T> may be confusing rustdoc or something, but take that with a grain of salt, it's just a guess.

@sfackler sfackler added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 23, 2014
@apasel422
Copy link
Contributor

This does appear to be related to the fact that the impls are for references. The IntoIterator impls for &BTreeSet and &mut BTreeSet (and the corresponding ones for the other collection types) have the same problem.

@alexcrichton alexcrichton self-assigned this Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants