-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up i686-{pc, w64}-mingw32 triples #15717
Comments
I want to get this cleanup up for 1.0. It affects the name of the download artefacts we present, which ideally shouldn't change immediately after launch. |
Categorizing as P-high, not a 1.0 blocker. |
I wonder if old LLVM's understand the new canonicalized triples or if we might need to 'uncanonicalize' them before passing them on. |
The in-tree LLVM does not understand |
Should we switch to the canonical triples anyway and decanonicalize for LLVM? cc @cmr |
@sunfishcode suggests we get on board the canonical triple train and decononicalize for LLVM. |
In fact, it appears to only be the in-tree LLVM configure script that doesn't understand the new windows trips. |
Yes. My target spec patch fixes this, actually. |
@cmr Do you want me to wait for you to land your patch? |
@brson, we got canonical triples figured out in @cmr's flex target branch. And yes, in order to build LLVM and other deps, we have to pass them the old triple: https://github.com/cmr/rust/commit/bac1b460519319cff4095d87253439f10e17bb16 |
This updates our build system to prefer `i686-w64-mingw32` as the 32-bit windows triple instead of `i686-pc-mingw32`. This is an interim step to make the build artifacts consistent until #15717 is done.
Done! |
As in, @cmr's target customization branch landed the renaming to |
We have two distinct triples:
i686-pc-mingw32
(mingw) andi686-w64-ming32
(mingw-w64). However, there seems no need to maintain two triples separately, and even buildbots actually have usedi686-pc-mingw32
on mingw-w64 without any issues.There are some minor differences in
mk/platform.mk
(e.g.i686-w64-mingw32
doesn't fix mingw-specific problems) but they are mergeable.The easiest fix is just to remove
i686-w64-mingw32
, and maybe some "redirection" (configure
automatically convertsi686-w64-mingw32
intoi686-pc-mingw32
) might be good too.(Recently llvm cleaned up windows triples: the two triples are now canonicalized as
i686-pc-windows-gnu
.)The text was updated successfully, but these errors were encountered: