Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing DLL when using regex! macro #13848

Closed
Seldaek opened this issue Apr 29, 2014 · 0 comments · Fixed by #13857
Closed

Missing DLL when using regex! macro #13848

Seldaek opened this issue Apr 29, 2014 · 0 comments · Fixed by #13857
Labels
A-syntaxext Area: Syntax extensions

Comments

@Seldaek
Copy link
Contributor

Seldaek commented Apr 29, 2014

If I import the regex! macro with this code:

#![feature(phase)]
#[phase(syntax)]
extern crate regex_macros;
extern crate regex;

Then the program fails to compile because of amissing DLL:

image
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 30, 2014
@alexcrichton
rustc: Add search paths to dylib load paths
1a367c6 
When a syntax extension is loaded by the compiler, the dylib that is opened may
have other dylibs that it depends on. The dynamic linker must be able to find
these libraries on the system or else the library will fail to load.

Currently, unix gets by with the use of rpaths. This relies on the dylib not
moving around too drastically relative to its dependencies. For windows,
however, this is no rpath available, and in theory unix should work without
rpaths as well.

This modifies the compiler to add all -L search directories to the dynamic
linker's set of load paths. This is currently managed through environment
variables for each platform.

Closes rust-lang#13848
@alexcrichton alexcrichton mentioned this issue Apr 30, 2014
Merged
bors added a commit that referenced this issue Apr 30, 2014
@bors
auto merge of #13857 : alexcrichton/rust/add-dylib-paths, r=brson
f77784b 
When a syntax extension is loaded by the compiler, the dylib that is opened may
have other dylibs that it depends on. The dynamic linker must be able to find
these libraries on the system or else the library will fail to load.

Currently, unix gets by with the use of rpaths. This relies on the dylib not
moving around too drastically relative to its dependencies. For windows,
however, this is no rpath available, and in theory unix should work without
rpaths as well.

This modifies the compiler to add all -L search directories to the dynamic
linker's set of load paths. This is currently managed through environment
variables for each platform.

Closes #13848
arcnmx pushed a commit to arcnmx/rust that referenced this issue Jan 9, 2023
@bors
Auto merge of rust-lang#13848 - ian-h-chamberlain:feature/color-compi…
368e0bb 
…ler-diagnostics, r=ian-h-chamberlain

Colorize `cargo check` diagnostics in VSCode via text decorations

Fixes rust-lang#13648

![colored-rustc-diagnostics](https://user-images.githubusercontent.com/11131775/209479884-10eef8ca-37b4-4aae-88f7-3591ac01b25e.gif)

Use ANSI control characters to display text decorations matching the VScode terminal theme, and strip them out when providing text content for rustc diagnostics.

This adds the small [`anser`](https://www.npmjs.com/package/anser) library (MIT license, no dependencies) to parse the control codes, and it also supports HTML output so it should be fairly easy to switch to a rendered HTML/webview implementation in the future

I also updated the default `cargo check` command to use the rendered ANSI diagnostics, although I'm not sure if it makes sense to put this kind of thing behind a feature flag, or whether it might have any issues on Windows (as I believe ANSI codes are not used for colorization there)?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-syntaxext Area: Syntax extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustc: Add search paths to dylib load paths alexcrichton/rust
2 participants
@alexcrichton @Seldaek