Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/assembly/x86_64-bigint-add.rs broken with LLVM 20 #133754

Open
krasimirgg opened this issue Dec 2, 2024 · 1 comment
Open

tests/assembly/x86_64-bigint-add.rs broken with LLVM 20 #133754

krasimirgg opened this issue Dec 2, 2024 · 1 comment
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@krasimirgg
Copy link
Contributor

krasimirgg commented Dec 2, 2024 •
edited
Loading

It looks like tests/assembly/x86_64-bigint-add.rs broken, newly added in 9836196, produces slightly different assembly with LLVM-at-HEAD:

https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/33017#01938775-555b-4915-9c10-08f40d14cdad/945-946

@scottmcm: does the new assembly produced look good? Happy to adapt the test for this.

cc: @scottmcm @durin42
@krasimirgg krasimirgg added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Dec 2, 2024
@krasimirgg
Copy link
Contributor Author

@rustbot label +A-LLVM

@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Dec 2, 2024
@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-testsuite Area: The testsuite used to check the correctness of rustc and removed C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@krasimirgg @jieyouxu @rustbot