Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a regression test for #132587 #132727

Open
jieyouxu opened this issue Nov 7, 2024 · 3 comments
Open

Add a regression test for #132587 #132727

jieyouxu opened this issue Nov 7, 2024 · 3 comments
Labels
A-parser Area: The parsing of Rust source code to an AST A-proc-macros Area: Procedural macros C-bug Category: This is a bug. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Nov 7, 2024

#132587 partially reverted #129346 because that caused a test failure in cfg_eval, but the revert PR didn't come with a test because it involved proc-macros and was hard to minimize. We should still add a regression test.

@rustbot label +E-needs-test
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. labels Nov 7, 2024
@jieyouxu
Copy link
Member Author

jieyouxu commented Nov 7, 2024

Initial report at #129346 (review)

@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. A-parser Area: The parsing of Rust source code to an AST and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 7, 2024
@jieyouxu
Copy link
Member Author

jieyouxu commented Nov 7, 2024

See also exploration in #132587, e.g. #132587 (comment)

@jieyouxu jieyouxu added the A-proc-macros Area: Procedural macros label Nov 16, 2024
@jieyouxu
Copy link
Member Author

I briefly looked at this and the minimization is tricky.

@rustbot label +E-medium

@rustbot rustbot added the E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser Area: The parsing of Rust source code to an AST A-proc-macros Area: Procedural macros C-bug Category: This is a bug. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieyouxu @rustbot