-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/debug-info: filename extension matters on windows #13256
Comments
Thanks for the report, I'll look into it. |
I can't reproduce this (anymore?). This seems to have been fixed in the meanwhile. Debuginfo generation picks up the correct crate name also on Windows. |
Closing for now, but of course feel free to reopen if it reproduces still! |
@alexcrichton Well, I wanted to re-enable the tests in question before closing the issue, which in turn I wanted to do after the current Windows-related PR had landed. Would you mind if I just update the open PR to enable the tests? The queue is quite long at the moment. |
Aha, of course! |
Done. Re-approve please: #18422 |
#18422 passed on buildbot, and |
make check-<stage>-debuginfo
compilessome-test.rs
intosome-test.<stage>-<target>
, which is actuallysome-test.<stage>-<target>.exe
on windows.This causes test failures on windows:
Relevant tests:
The text was updated successfully, but these errors were encountered: