Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can ./x doc xxx be exercised in PR CI or earlier? #131613

Open
jieyouxu opened this issue Oct 12, 2024 · 1 comment
Open

Can ./x doc xxx be exercised in PR CI or earlier? #131613

jieyouxu opened this issue Oct 12, 2024 · 1 comment
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Oct 12, 2024 •
edited
Loading

Tool docs like ./x doc src/tools/compiletest seemingly are run very late into the full CI pipeline, but that seems relatively easy and cheap to either run in PR CI or perhaps earlier in full CI? That might help to catch trivial broken intradoc links which can fail full CI like 2 hours in...

Not sure about compiler/std docs, but some tool docs might be okay to move earlier into the pipelines?

T-infra zulip link: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Can.20some.20doc.20checks.20happen.20in.20PR.20CI.20or.20happen.20earlier.3F
@jieyouxu jieyouxu added C-discussion Category: Discussion or questions that doesn't represent real issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 12, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 12, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 12, 2024
@jieyouxu jieyouxu mentioned this issue Oct 12, 2024
Merged
@jieyouxu
Copy link
Member Author

Didn't quite figure out when the link check can be too late.

@jieyouxu jieyouxu added the E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. E-needs-investigation Call for partcipation: This issues needs some investigation to determine current status T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieyouxu @rustbot