Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit hook for ./x.py fmt appears to not always know which files were changed. #125287

Open
zachs18 opened this issue May 19, 2024 · 0 comments
Open

pre-commit hook for ./x.py fmt appears to not always know which files were changed. #125287

zachs18 opened this issue May 19, 2024 · 0 comments
Labels
C-bug Category: This is a bug. S-needs-repro Status: This issue has no reproduction and needs a reproduction to make progress.

Comments

@zachs18
Copy link
Contributor

zachs18 commented May 19, 2024

I tried this PR: #125283 (original push was just the first two commits, which have invalid formatting)

I expected to see this happen: git push pre-commit-hook should have noticed that the formatting for library/alloc/src/sync.rs was invalid in the pre-commit hook.

Instead, this happened: The push completed successfully.

I haven't been able to reproduce the issue (intentionally trying to push code with invalid formatting is caught by the pre-commit-hook in the times I've tried since).
@zachs18 zachs18 added the C-bug Category: This is a bug. label May 19, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label May 19, 2024
@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself S-needs-repro Status: This issue has no reproduction and needs a reproduction to make progress. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels May 22, 2024
@onur-ozkan onur-ozkan removed A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. S-needs-repro Status: This issue has no reproduction and needs a reproduction to make progress.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zachs18 @jieyouxu @onur-ozkan @rustbot