Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking Issue for RFC 3543 patchable-function-entry #123115

Open
1 of 3 tasks
traviscross opened this issue Mar 27, 2024 · 1 comment
Open
1 of 3 tasks

Tracking Issue for RFC 3543 patchable-function-entry #123115

traviscross opened this issue Mar 27, 2024 · 1 comment
Assignees
@nebulark
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-patchable_function_entry #![feature(patchable_function_entry)] T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@traviscross
Copy link
Contributor

traviscross commented Mar 27, 2024 •
edited by workingjubilee
Loading

This is a tracking issue for the RFC 3543 patchable-function-entry (rust-lang/rfcs#3543).

The feature gate for the issue is #![feature(patchable_function_entry)].

This is support for patchable-function-entry as present in clang and gcc. This feature is generally used to allow hotpatching and instrumentation of code.

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

  • Should we use LLVM or gcc/clang style for a per-function attribute? Should we support both styles?
  • Should we support a more explicit command line argument style?
  • Should we reject linking crates with different default padding configurations?
@traviscross traviscross added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-lang Relevant to the language team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. F-patchable_function_entry #![feature(patchable_function_entry)] labels Mar 27, 2024
@traviscross traviscross mentioned this issue Mar 27, 2024
Merged
@compiler-errors compiler-errors mentioned this issue Mar 28, 2024
Merged
@nebulark nebulark mentioned this issue May 5, 2024
Merged
@nebulark
Copy link
Contributor

nebulark commented May 5, 2024

@rustbot claim

@ojeda ojeda mentioned this issue Jun 22, 2024
Open
52 tasks
jhpratt added a commit to jhpratt/rust that referenced this issue Jun 28, 2024
@jhpratt
Rollup merge of rust-lang#124741 - nebulark:patchable-function-entrie…
f432014 
…s-pr, r=estebank,workingjubilee

patchable-function-entry: Add unstable compiler flag and attribute

Tracking issue: rust-lang#123115

Add the -Z patchable-function-entry compiler flag and the #[patchable_function_entry(prefix_nops = m, entry_nops = n)] attribute.
Rebased and adjusted the canditate implementation to match changes in the RFC.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jun 28, 2024
@matthiaskrgr
Rollup merge of rust-lang#124741 - nebulark:patchable-function-entrie…
e0439d9 
…s-pr, r=estebank,workingjubilee

patchable-function-entry: Add unstable compiler flag and attribute

Tracking issue: rust-lang#123115

Add the -Z patchable-function-entry compiler flag and the #[patchable_function_entry(prefix_nops = m, entry_nops = n)] attribute.
Rebased and adjusted the canditate implementation to match changes in the RFC.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jun 28, 2024
@matthiaskrgr
Rollup merge of rust-lang#124741 - nebulark:patchable-function-entrie…
75834c9 
…s-pr, r=estebank,workingjubilee

patchable-function-entry: Add unstable compiler flag and attribute

Tracking issue: rust-lang#123115

Add the -Z patchable-function-entry compiler flag and the #[patchable_function_entry(prefix_nops = m, entry_nops = n)] attribute.
Rebased and adjusted the canditate implementation to match changes in the RFC.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jun 28, 2024
@matthiaskrgr
Rollup merge of rust-lang#124741 - nebulark:patchable-function-entrie…
0262932 
…s-pr, r=estebank,workingjubilee

patchable-function-entry: Add unstable compiler flag and attribute

Tracking issue: rust-lang#123115

Add the -Z patchable-function-entry compiler flag and the #[patchable_function_entry(prefix_nops = m, entry_nops = n)] attribute.
Rebased and adjusted the canditate implementation to match changes in the RFC.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jun 28, 2024
@rust-timer
Unrolled build for rust-lang#124741
fd5454e 
Rollup merge of rust-lang#124741 - nebulark:patchable-function-entries-pr, r=estebank,workingjubilee

patchable-function-entry: Add unstable compiler flag and attribute

Tracking issue: rust-lang#123115

Add the -Z patchable-function-entry compiler flag and the #[patchable_function_entry(prefix_nops = m, entry_nops = n)] attribute.
Rebased and adjusted the canditate implementation to match changes in the RFC.
@ojeda ojeda mentioned this issue Jun 28, 2024
Open
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nebulark nebulark

Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-patchable_function_entry #![feature(patchable_function_entry)] T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@traviscross @nebulark