Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge generalizer impls #111092

Closed
lcnr opened this issue May 2, 2023 · 0 comments · Fixed by #111221
Closed

merge generalizer impls #111092

lcnr opened this issue May 2, 2023 · 0 comments · Fixed by #111221
Labels
A-type-system Area: Type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.

Comments

@lcnr
Copy link
Contributor

lcnr commented May 2, 2023

we currently have 3 different implementations of "generalization":

https://doc.rust-lang.org/nightly/nightly-rustc/rustc_infer/infer/combine/struct.Generalizer.html

https://doc.rust-lang.org/nightly/nightly-rustc/rustc_infer/infer/nll_relate/struct.TypeGeneralizer.html

https://doc.rust-lang.org/nightly/nightly-rustc/rustc_infer/infer/combine/struct.ConstInferUnifier.html

These 3 should have the same behavior and should be merged.

cc #109813 where we have to do the same change in each of the generalizers.
@lcnr lcnr added C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. labels May 2, 2023
@jyn514 jyn514 added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-inference Area: Type inference labels May 2, 2023
@compiler-errors compiler-errors added A-type-system Area: Type system T-types Relevant to the types team, which will review and decide on the PR/issue. and removed A-inference Area: Type inference labels May 2, 2023
@compiler-errors compiler-errors mentioned this issue May 4, 2023
Merged
@bors bors closed this as completed in ea54255 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-type-system Area: Type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Combine three generalizer implementations compiler-errors/rust
3 participants
@compiler-errors @jyn514 @lcnr