From a95c71e0ac3dc97468d7432d5011fbb413ba9263 Mon Sep 17 00:00:00 2001 From: Murarth Date: Sun, 23 Nov 2014 22:22:07 -0700 Subject: [PATCH 1/2] Fixed "::::" appearing in module_path!() --- src/libsyntax/ext/expand.rs | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/libsyntax/ext/expand.rs b/src/libsyntax/ext/expand.rs index 04132679a0370..a697d332d16af 100644 --- a/src/libsyntax/ext/expand.rs +++ b/src/libsyntax/ext/expand.rs @@ -412,12 +412,19 @@ pub fn expand_item(it: P, fld: &mut MacroExpander) let mut new_items = match it.node { ast::ItemMac(..) => expand_item_mac(it, fld), ast::ItemMod(_) | ast::ItemForeignMod(_) => { - fld.cx.mod_push(it.ident); + let valid_ident = + it.ident.name != parse::token::special_idents::invalid.name; + + if valid_ident { + fld.cx.mod_push(it.ident); + } let macro_escape = contains_macro_escape(new_attrs.as_slice()); let result = with_exts_frame!(fld.cx.syntax_env, macro_escape, noop_fold_item(it, fld)); - fld.cx.mod_pop(); + if valid_ident { + fld.cx.mod_pop(); + } result }, _ => { From 6a5fc50782905cede94ae9bdaa04e3b07347c4be Mon Sep 17 00:00:00 2001 From: Murarth Date: Sun, 23 Nov 2014 22:24:38 -0700 Subject: [PATCH 2/2] Added test for module_path! fix --- src/test/run-pass/issue-18859.rs | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 src/test/run-pass/issue-18859.rs diff --git a/src/test/run-pass/issue-18859.rs b/src/test/run-pass/issue-18859.rs new file mode 100644 index 0000000000000..490f7eb6bea4b --- /dev/null +++ b/src/test/run-pass/issue-18859.rs @@ -0,0 +1,24 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +mod foo { + pub mod bar { + pub mod baz { + pub fn name() -> &'static str { + module_path!() + } + } + } +} + +fn main() { + assert_eq!(module_path!(), "issue-18859"); + assert_eq!(foo::bar::baz::name(), "issue-18859::foo::bar::baz"); +}