-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange error message when passing ill-typed code to Miri #458
Comments
This is for any usage of Miri on the playground which includes a crate: fn main() {
memchr::memchr(0, &[]);
} This has been present since Miri was introduced on the playground, AFAIR; TBH I assumed that Miri didn't handle crates yet. |
I wonder if this shares commonalities with rust-lang/rust#57854, which is a similar "why is an external crate coming into play anyway". |
But my example doesn't use a crate, does it? Miri works fine with crates locally. |
How do these other crates get built? Maybe the issue is that they don't get built against Miri's sysroot. |
Right, and neither does the linked issue. Both just have the crates "hanging around". |
Miri starts from the existing nightly container. The base compiler containers just run
Very likely. Does this mean that the Miri container needs to rebuild all the crates? Clippy already does this, so it might be time to reorganize the build process. |
Yes. They have to be built against the sysroot in |
What's the invocation for that? You're more familiar with our build process w.r.t. Miri. |
You have a |
Is this required? Docker has additive filesystems, deleting stuff from a previous layer doesn't save any space.
Presumably with at least a |
Without the Yes, having an empty main makes sense (or the command will likely fail -- it did all its work by then, but still, that'd be ugly). |
Implicitly fixed by #460 ? |
Indeed, thanks :) |
This example shows the following error when hitting "Run":
But when I send it to Miri, I get
The text was updated successfully, but these errors were encountered: