fallout: fix tests to allow uninlined_format_args #9547
Conversation
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #9516) made this pull request unmergeable. Please resolve the merge conflicts. |
nyurik
changed the title
There was a problem hiding this comment.
This adds an allow attribute for the uninlined_format_args lint for every test file, even if it doesn't even use the format! macro. This is highly unnecessary and not something we want. Please only add this attribute to the tests that would actually fail due to the new lint.
@flip1995 that is not correct - there are 801 test .rs files in the |
|
☔ The latest upstream changes (presumably #9479) made this pull request unmergeable. Please resolve the merge conflicts. |
In order to switch `clippy::uninlined_format_args` from pedantic to style, all existing tests must not raise a warning. I did not want to change the actual tests, so this is a relatively minor change that: * add `#![allow(clippy::uninlined_format_args)]` where needed * normalizes all allow/deny/warn attributes * all allow attributes are grouped together * sorted alphabetically * the `clippy::*` attributes are listed separate from the other ones. * deny and warn attributes are listed before the allowed ones changelog: none
|
@flip1995 is there still something that needs to be done to this PR? Thx! |
|
@bors r+ p=10 |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
In order to switch
clippy::uninlined_format_argsfrom pedantic to style, all existing tests must not raise a warning. I did not want to change the actual tests, so this is a relatively minor change that:#![allow(clippy::uninlined_format_args)]where neededclippy::*attributes are listed separate from the other ones.See also #9233, #9525, #9527
cc: @llogiq @Alexendoo
changelog: none