return_self_not_must_use document #[must_use] on the type
#8209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
xFrednet
force-pushed
the
8197-mention-attribute-on-struct
branch
from
a219ca6
to
2d3b1ae
Compare
llogiq
reviewed
Jan 1, 2022
There was a problem hiding this comment.
Small documentation nit. I believe @GuillaumeGomez also had some suggestion.
xFrednet
force-pushed
the
8197-mention-attribute-on-struct
branch
from
2d3b1ae
to
27b297c
Compare
GuillaumeGomez
approved these changes
Jan 1, 2022
|
Good suggestions, it seems like I'm not fully awake yet^^. I squashed and pushed both! |
|
Thanks for the improvements! |
|
Thank you! @bors r+ squash |
|
📌 Commit c049d1e has been approved by |
bors
added a commit
that referenced
this pull request
Jan 1, 2022
…ogiq return_self_not_must_use document `#[must_use]` on the type Inspired by a discussion in #8197 --- r? `@llogiq` changelog: none The lint is this on nightly, therefore no changelog entry for you xD
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
bors squash-merged it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by a discussion in #8197
r? @llogiq
changelog: none
The lint is this on nightly, therefore no changelog entry for you xD