Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Test if clippy got much slower over the last few days #4712

Closed
wants to merge 8 commits into from

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 22, 2019

The aid is to check if clippy got much slower over the last few days.
And check if its cause is #4703.

changelog: none

@tesuji
Copy link
Contributor Author

tesuji commented Oct 22, 2019

After merging #4702, clippy integration tests got much slower.

The test time for log in #4702: 25.05s

But in another build after that PR, it got much slower:

@tesuji
Copy link
Contributor Author

tesuji commented Oct 22, 2019

Closed and reopend to trigger rebuild.

@tesuji tesuji closed this Oct 22, 2019
@tesuji tesuji reopened this Oct 22, 2019
@phansch
Copy link
Member

phansch commented Oct 22, 2019

Note that Clippy is not building right now due to rust-lang/rust#65647. The integration tests don't fail even if they should?

@tesuji
Copy link
Contributor Author

tesuji commented Oct 22, 2019

The integration tests don't fail even if they should

Should be fixed in #4675

@tesuji tesuji closed this Oct 23, 2019
@tesuji tesuji reopened this Oct 23, 2019
@tesuji tesuji closed this Oct 23, 2019
@tesuji tesuji reopened this Oct 23, 2019
The aid is to check if clippy got much slower over the last few days.
But not because of rust-lang#4703.
@tesuji tesuji force-pushed the test-if-clippy-got-much-slow branch from 953de1f to 1e9e62e Compare October 23, 2019 17:49
@tesuji tesuji closed this Oct 23, 2019
@tesuji tesuji deleted the test-if-clippy-got-much-slow branch October 23, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants