Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use clippy's debug build in integration test #4702

Merged
merged 1 commit into from
Oct 20, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 19, 2019

changelog: none

@tesuji tesuji force-pushed the build/debug-integration-clippy branch 3 times, most recently from ed024c7 to 9a1528d Compare October 19, 2019 14:09
@tesuji
Copy link
Contributor Author

tesuji commented Oct 19, 2019

Some improvements:

INTEGRATION old 1st 2nd 3rd
rust-lang-nursery/failure 338.19s, 327.33s, 347.03s 239.35s 239.86s 239.98s
rust-lang-nursery/log 330.47s, 315.87s, 325.43s 234.61s 238.42s 247.43s

@tesuji tesuji force-pushed the build/debug-integration-clippy branch from 9a1528d to d4fef9f Compare October 19, 2019 14:46
@tesuji tesuji changed the title [WIP] build: use clippy's debug build in integration test build: use clippy's debug build in integration test Oct 19, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Oct 19, 2019

Ready for review.

@phansch
Copy link
Member

phansch commented Oct 20, 2019

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Oct 20, 2019

📌 Commit d4fef9f has been approved by phansch

@bors
Copy link
Contributor

bors commented Oct 20, 2019

⌛ Testing commit d4fef9f with merge 1d0f625...

bors added a commit that referenced this pull request Oct 20, 2019
build: use clippy's debug build in integration test

changelog: none
@bors
Copy link
Contributor

bors commented Oct 20, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 1d0f625 to master...

@bors bors merged commit d4fef9f into rust-lang:master Oct 20, 2019
@tesuji tesuji deleted the build/debug-integration-clippy branch October 20, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants