Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update needless_bool test stderr #4128

Merged
merged 1 commit into from
May 23, 2019

Conversation

matthiaskrgr
Copy link
Member

I'm getting a test failure otherwise with rust master (f688ba6).

changelog: none

I'm getting a test failure otherwise with rust master (f688ba6).
@matthiaskrgr
Copy link
Member Author

Looks like rust-lang/rust#61074 failed due to this

@phansch
Copy link
Member

phansch commented May 23, 2019

@bors r+ I will update the Rust PR once this is merged :)

@bors
Copy link
Contributor

bors commented May 23, 2019

📌 Commit 3d0795b has been approved by phansch

bors added a commit that referenced this pull request May 23, 2019
tests: update needless_bool test stderr

I'm getting a test failure otherwise with rust master (f688ba6).

changelog: none
@bors
Copy link
Contributor

bors commented May 23, 2019

⌛ Testing commit 3d0795b with merge 9c85b02...

@bors
Copy link
Contributor

bors commented May 23, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 9c85b02 to master...

@bors bors merged commit 3d0795b into rust-lang:master May 23, 2019
@phansch
Copy link
Member

phansch commented Aug 4, 2019

Hmm in retrospect this change has broken that specific suggestion:

If

LL |       } else if returns_bool() {
   |  ____________^
LL | |         false
LL | |     } else {
LL | |         true
LL | |     };
   | |_____^ help: you can reduce it to: `!returns_bool()`

is applied, it results in:

if foo {
  // ...
} else !returns_bool()

I think that's because

if parent_node_is_if_expr(&e, &cx) {

is not true anymore. I will take a look. (opened #4334)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants