Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete comment and simplify code #14264

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

samueltardieu
Copy link
Contributor

The IoBufRead diagnostic has been added during the latest rustup.

changelog: none

The `IoBufRead` diagnostic has been added during the latest rustup.
@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2025

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 20, 2025
@samueltardieu
Copy link
Contributor Author

@Manishearth Is there something you need before you merge it (looks like the approval is not enough to have it merged automatically)?

@Manishearth Manishearth added this pull request to the merge queue Feb 20, 2025
@Manishearth
Copy link
Member

No, I just forgot to hit merge. Generally if I approve without comments you should feel free to click merge yourself!

Merged via the queue into rust-lang:master with commit 732e329 Feb 20, 2025
11 checks passed
@samueltardieu
Copy link
Contributor Author

Generally if I approve without comments you should feel free to click merge yourself!

I would have, but I don't have the necessary access rights.

@samueltardieu samueltardieu deleted the push-kowvlylnqzny branch February 21, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants