Lint more cases in collapsible_if, without suggestions
#14231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-uopxwlslsuwp
branch
2 times, most recently
from
b8d9f37 to
a94f321
Compare
|
I think I'll add a configuration option to merge @rustbot author |
rustbot
added
S-waiting-on-author
samueltardieu
force-pushed
the
push-uopxwlslsuwp
branch
from
a94f321 to
bc44671
Compare
|
Done, with the @rustbot review |
rustbot
added
S-waiting-on-review
samueltardieu
force-pushed
the
push-uopxwlslsuwp
branch
from
bc44671 to
419a0a2
Compare
Due to its use of `Sugg::ast()` to combine `if` conditions together, `collapsible_if` cannot keep comments located inside the conditions or between the conditions in its suggestions. However, it is still possible to warn about those situations and let the user fix their code by themselves. A new configuration option `lint_commented_code`, which is `true` by default, opts out from this behavior.
samueltardieu
force-pushed
the
push-uopxwlslsuwp
branch
from
419a0a2 to
24c2681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to its use of
Sugg::ast()to combineifconditions together,collapsible_ifcannot keep comments located inside the conditions or between the conditions in its suggestions. However, it is still possible to warn about those situations and let the user fix their code by themselves.If reviewed on GitHub, the second commit of this PR is best looked at side by side, with whitespace differences turned off.
changelog: [
collapsible_if]: lint more cases