Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change defaults of accept-comment-above-statement and accept-comment-above-attributes #11170

Merged
merged 1 commit into from
Sep 20, 2023

Commits on Sep 20, 2023

  1. Change default configuration of undocumented_unsafe_blocks

    This patch sets the two configuration options for
    `undocumented_unsafe_blocks` to `true` by default: these are
    `accept-comment-above-statement` and `accept-comment-above-attributes`.
    Having these values `false` by default prevents what many users would
    consider clean code, e.g. placing the `// SAFETY:` comment above a
    single-line functino call, rather than directly next to the argument.
    
    changelog: [`undocumented_unsafe_blocks`]: set
    `accept-comment-above-statement` and `accept-comment-above-attributes`
    to `true` by default.
    tgross35 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    1b3e5dd View commit details
    Browse the repository at this point in the history