Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint fn new() -> Self without Default #705

Closed
mcarton opened this issue Feb 24, 2016 · 2 comments
Closed

Lint fn new() -> Self without Default #705

mcarton opened this issue Feb 24, 2016 · 2 comments
Labels
A-lint Area: New lints E-medium Call for participation: Medium difficulty level problem and requires some initial experience.

Comments

@mcarton
Copy link
Member

mcarton commented Feb 24, 2016

@vi just suggested to have a lint “for having fn new() -> Self, but not having Default” on IRC.
That’s probably a good idea, but it might trigger a lot, so maybe an Allow lint by default?
@mcarton mcarton added E-medium Call for participation: Medium difficulty level problem and requires some initial experience. A-lint Area: New lints labels Feb 24, 2016
@Manishearth
Copy link
Member

Not sure if it needs to be Allow, but sure :)

@llogiq
Copy link
Contributor

llogiq commented Feb 24, 2016

I'd be OK with warn, too.

@vi vi mentioned this issue Feb 25, 2016
Closed
@mcarton mcarton mentioned this issue Mar 1, 2016
Merged
@vi vi mentioned this issue Apr 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints E-medium Call for participation: Medium difficulty level problem and requires some initial experience.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Manishearth @mcarton @llogiq