Make unnecessary_map_or work with ref and Deref to Option/Result
#14024
+219
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
push-mskzusqnmtsk
branch
from
5b8523e to
25342b1
Compare
A multipart suggestion will be used whenever the method call can be replaced by another one with the first argument removed. It helps place the new method call in context, especially when it is part of a larger expression.
Receivers which are references to `Option` and `Result`, or who implement `Deref` to one of those types, will be linted as well.
samueltardieu
force-pushed
the
push-mskzusqnmtsk
branch
from
25342b1 to
27592e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receivers which are references to
OptionandResult, or who implementDerefto one of those types, will be linted as well.changelog: [
unnecessary_map_or]: work with ref andDereftoOptionandResultas wellFixes #14023
Note: this patch must be merged after #13998 – only the second commit must be reviewed, the first one repeats the patch in #13998 for mergeability reasons.