Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming convention #1335

Closed
mcarton opened this issue Nov 9, 2016 · 3 comments · Fixed by #6475
Closed

Naming convention #1335

mcarton opened this issue Nov 9, 2016 · 3 comments · Fixed by #6475
Labels
A-lint Area: New lints good-first-issue These issues are a good way to get started with Clippy T-AST Type: Requires working with the AST

Comments

@mcarton
Copy link
Member

mcarton commented Nov 9, 2016

At work I have a VS plugin warning about names such as TOMLParser. According to Rust's naming conventions, this should be TomlParser.
We should warn on more that 2 consecutive capital letters in a name.
@Manishearth
Copy link
Member

I'd be wary of this, because of the amount of false positives it may cause. We used to do this but turned it off.

(Separate lint maybe?)

@oli-obk
Copy link
Contributor

oli-obk commented Nov 9, 2016

CString is an example of such a false positive

@mcarton
Copy link
Member Author

mcarton commented Nov 9, 2016

*strictly more than 2

@mcarton mcarton added good-first-issue These issues are a good way to get started with Clippy A-lint Area: New lints T-AST Type: Requires working with the AST labels Nov 11, 2016
@giraffate giraffate mentioned this issue Nov 6, 2020
Closed
@hkmatsumoto hkmatsumoto mentioned this issue Dec 19, 2020
Merged
@bors bors closed this as completed in e6665e4 Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: New lints good-first-issue These issues are a good way to get started with Clippy T-AST Type: Requires working with the AST
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new lint upper_case_acronyms hkmatsumoto/rust-clippy
3 participants
@oli-obk @Manishearth @mcarton