From 0e52a0ed6d5aeb7e93d3b1cbf5d2ccb9a49ec4c2 Mon Sep 17 00:00:00 2001 From: Eduard-Mihai Burtescu Date: Sun, 26 Jan 2020 03:12:44 +0200 Subject: [PATCH] Don't use ExpnKind::descr to get the name of a bang macro. --- clippy_lints/src/utils/mod.rs | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/clippy_lints/src/utils/mod.rs b/clippy_lints/src/utils/mod.rs index 8918cbfa59b1..d1849a7c3141 100644 --- a/clippy_lints/src/utils/mod.rs +++ b/clippy_lints/src/utils/mod.rs @@ -42,7 +42,7 @@ use rustc_hir::intravisit::{NestedVisitorMap, Visitor}; use rustc_hir::Node; use rustc_hir::*; use rustc_lint::{LateContext, Level, Lint, LintContext}; -use rustc_span::hygiene::ExpnKind; +use rustc_span::hygiene::{ExpnKind, MacroKind}; use rustc_span::symbol::{self, kw, Symbol}; use rustc_span::{BytePos, Pos, Span, DUMMY_SP}; use smallvec::SmallVec; @@ -758,14 +758,15 @@ pub fn is_expn_of(mut span: Span, name: &str) -> Option { loop { if span.from_expansion() { let data = span.ctxt().outer_expn_data(); - let mac_name = data.kind.descr(); let new_span = data.call_site; - if mac_name.as_str() == name { - return Some(new_span); - } else { - span = new_span; + if let ExpnKind::Macro(MacroKind::Bang, mac_name) = data.kind { + if mac_name.as_str() == name { + return Some(new_span); + } } + + span = new_span; } else { return None; } @@ -785,17 +786,16 @@ pub fn is_expn_of(mut span: Span, name: &str) -> Option { pub fn is_direct_expn_of(span: Span, name: &str) -> Option { if span.from_expansion() { let data = span.ctxt().outer_expn_data(); - let mac_name = data.kind.descr(); let new_span = data.call_site; - if mac_name.as_str() == name { - Some(new_span) - } else { - None + if let ExpnKind::Macro(MacroKind::Bang, mac_name) = data.kind { + if mac_name.as_str() == name { + return Some(new_span); + } } - } else { - None } + + None } /// Convenience function to get the return type of a function.